Updated for MVP deployment #1
Merged
+111
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patel385
reviewed
Oct 23, 2024
patel385
reviewed
Oct 23, 2024
| ] | ||
|
|
||
| chart = "kiali" | ||
| name = "kiali" | ||
| namespace = local.ns | ||
| repository = "${path.module}/charts" | ||
| repository = "./charts" | ||
| # repository = "${path.module}/charts" |
There was a problem hiding this comment.
☝️ commented repository key / value can be removed?
patel385
reviewed
Oct 23, 2024
| # gogatekeeper_registry = var.gogatekeeper_registry | ||
| # gogatekeeper_repository = var.gogatekeeper_repository | ||
| # gogatekeeper_tag = var.gogatekeeper_tag | ||
| # } |
There was a problem hiding this comment.
Is this block kept for future use? Even so, we can always pull from previous commits, yeah?
|
Apart from removing dead code, rest looks good. I can approve / merge if you want to take care of that in next PR. |
morga471
approved these changes
Oct 24, 2024
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.